Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image crop modal failing to show #2118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix image crop modal failing to show #2118

wants to merge 1 commit into from
+2 −1

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Dec 19, 2024 •
edited
Loading

Fixes #1631

If the controller is being dismissed, we shouldn't be presenting from that controller.

Test Plan

No longer getting

[UIKitCore] Attempt to present <TOCropViewController: 0x104840200> on
<PHPickerViewController: 0x12bf0ece0> (from <PHPickerViewController: 0x12bf0ece0>) whose
view is not in the window hierarchy.

when trying to present the cropper right after the Expo image picker.

See the video in bluesky-social/social-app#7194 to show the interaction. Before the fix, we were getting that log and the cropper would not show up.

This was referenced Dec 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openCropper is not working for IOS: view is not in the window hierarchy
1 participant
@gaearon