Merge pull request project-chip#204 from ivmarkov/fix-clippy-errs

Fix errors reported by latest Clippy
ivmarkov · Sep 14, 2024 · 2dc8cff · 2dc8cff
2 parents 1e0117b + a9a2cfd
commit 2dc8cff
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/ci-tlv-tool.yml b/.github/workflows/ci-tlv-tool.yml
@@ -43,7 +43,7 @@ jobs:
         working-directory: tools/tlv
 
       - name: Archive artifacts
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: tlv
           path: tools/tlv/target/debug/tlv
diff --git a/rs-matter/src/cert/mod.rs b/rs-matter/src/cert/mod.rs
@@ -805,14 +805,14 @@ impl<'a> CertVerifier<'a> {
         let asn1 = &asn1[..len];
 
         let k = KeyPair::new_from_public(parent.get_pubkey())?;
-        k.verify_msg(asn1, self.cert.get_signature()).map_err(|e| {
-            error!(
-                "Error in signature verification of certificate: {:x?} by {:x?}",
-                self.cert.get_subject_key_id(),
-                parent.get_subject_key_id()
-            );
-            e
-        })?;
+        k.verify_msg(asn1, self.cert.get_signature())
+            .inspect_err(|e| {
+                error!(
+                    "Error {e} in signature verification of certificate: {:x?} by {:x?}",
+                    self.cert.get_subject_key_id(),
+                    parent.get_subject_key_id()
+                );
+            })?;
 
         // TODO: other validation checks
         Ok(CertVerifier::new(parent))

diff --git a/rs-matter/src/mdns/proto.rs b/rs-matter/src/mdns/proto.rs
@@ -586,7 +586,7 @@ impl<'a> Service<'a> {
             for (k, v) in self.txt_kvs {
                 octets.append_slice(&[(k.len() + v.len() + 1) as u8])?;
                 octets.append_slice(k.as_bytes())?;
-                octets.append_slice(&[b'='])?;
+                octets.append_slice(b"=")?;
                 octets.append_slice(v.as_bytes())?;
             }