Start optimizing large stack sizes

clippy.toml

@@ -0,0 +1,4 @@
+future-size-threshold = 2048
+stack-size-threshold = 3048
+pass-by-value-size-limit = 16
+large-error-threshold = 64

src/lib.rs

@@ -5,6 +5,8 @@
 #![allow(unexpected_cfgs)]
 #![allow(clippy::declare_interior_mutable_const)]
 #![warn(clippy::large_futures)]
+#![warn(clippy::large_stack_frames)]
+#![warn(clippy::large_types_passed_by_value)]
 
 use core::net::{Ipv6Addr, SocketAddr, SocketAddrV6};
 use core::pin::pin;
@@ -115,6 +117,8 @@ where
 {
     /// Create a new `MatterStack` instance.
     #[cfg(feature = "std")]
+    #[allow(clippy::large_stack_frames)]
+    #[inline(always)]
     pub const fn new_default(
         dev_det: &'a BasicInfoConfig,
         dev_att: &'a dyn DevAttDataFetcher,
@@ -129,6 +133,8 @@ where
     }
 
     /// Create a new `MatterStack` instance.
+    #[allow(clippy::large_stack_frames)]
+    #[inline(always)]
     pub const fn new(
         dev_det: &'a BasicInfoConfig,
         dev_att: &'a dyn DevAttDataFetcher,

src/persist.rs

@@ -376,6 +376,8 @@ impl<E> KvBlobBuf<E>
 where
     E: Embedding,
 {
+    #[allow(clippy::large_stack_frames)]
+    #[inline(always)]
     const fn new() -> Self {
         Self {
             buf: PooledBuffers::new(0),

src/wifi/comm.rs

@@ -3,8 +3,8 @@ use embassy_sync::blocking_mutex::raw::RawMutex;
 use log::{error, info, warn};
 
 use rs_matter::data_model::objects::{
-    AsyncHandler, AttrDataEncoder, AttrDataWriter, AttrDetails, AttrType, CmdDataEncoder,
-    CmdDetails, Dataver,
+    AttrDataEncoder, AttrDataWriter, AttrDetails, AttrType, CmdDataEncoder, CmdDetails, Dataver,
+    Handler,
 };
 use rs_matter::data_model::sdm::nw_commissioning::{
     AddWifiNetworkRequest, Attributes, Commands, ConnectNetworkRequest, ConnectNetworkResponse,
@@ -118,7 +118,7 @@ where
     }
 
     /// Invoke a command.
-    pub async fn invoke(
+    pub fn invoke(
         &self,
         exchange: &Exchange<'_>,
         cmd: &CmdDetails<'_>,
@@ -140,8 +140,7 @@ where
             }
             Commands::ConnectNetwork => {
                 info!("ConnectNetwork");
-                self.connect_network(exchange, &ConnectNetworkRequest::from_tlv(data)?, encoder)
-                    .await?;
+                self.connect_network(exchange, &ConnectNetworkRequest::from_tlv(data)?, encoder)?;
             }
             Commands::ReorderNetwork => {
                 info!("ReorderNetwork");
@@ -307,7 +306,7 @@ where
         })
     }
 
-    async fn connect_network(
+    fn connect_network(
         &self,
         _exchange: &Exchange<'_>,
         req: &ConnectNetworkRequest<'_>,
@@ -425,26 +424,22 @@ where
     }
 }
 
-impl<'a, const N: usize, M> AsyncHandler for WifiNwCommCluster<'a, N, M>
+impl<'a, const N: usize, M> Handler for WifiNwCommCluster<'a, N, M>
 where
     M: RawMutex,
 {
-    async fn read<'m>(
-        &'m self,
-        attr: &'m AttrDetails<'_>,
-        encoder: AttrDataEncoder<'m, '_, '_>,
-    ) -> Result<(), Error> {
+    fn read(&self, attr: &AttrDetails, encoder: AttrDataEncoder) -> Result<(), Error> {
         WifiNwCommCluster::read(self, attr, encoder)
     }
 
-    async fn invoke<'m>(
-        &'m self,
-        exchange: &'m Exchange<'_>,
-        cmd: &'m CmdDetails<'_>,
-        data: &'m TLVElement<'_>,
-        encoder: CmdDataEncoder<'m, '_, '_>,
+    fn invoke(
+        &self,
+        exchange: &Exchange<'_>,
+        cmd: &CmdDetails,
+        data: &TLVElement,
+        encoder: CmdDataEncoder,
     ) -> Result<(), Error> {
-        WifiNwCommCluster::invoke(self, exchange, cmd, data, encoder).await
+        WifiNwCommCluster::invoke(self, exchange, cmd, data, encoder)
     }
 }