-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative take on the instance list rewrite #76
base: master
Are you sure you want to change the base?
Conversation
4bbec92
to
e4248a2
Compare
If you plan to add this I would love to have a box for ISP (some ISPs are better with privacy than others). |
What do you mean by "a box for ISP"? |
A box that shows the instance's host/Internet Service Provider. (ie. invidious.snopyta.org is on Hetzner) |
Oh, you mean a column about the hosting provider in the table? We could do that, but the issue is that it would get outdated very quickly because the administrators of Invidious instances change the host from time. But we could like update it automatically with a script. |
True, could you do something like this with GitHub actions. |
iv-org/documentation#76 This also contains a breaking changes to the API: - The flag and region values has been moved. They're now within the country dict on the JSON response
I'd suggest the following things:
|
5c48b3c
to
d4f2fbc
Compare
Eventually, the owners attribute needs to support urls other than Github. |
Hmm. The design of the onion instance table needs to be changed, it really doesn't look great with the new notes column. |
Why not going for a footnotes style?
Notes:
|
The notes column is technically allowed to be anything. And as such, the footnotes has the possibility of getting bloated fast. There's no way to directly link to a footnote either, so accessing them becomes a problem once the list is large enough. |
5017f2a
to
84928c8
Compare
50846a2
to
b3bb76a
Compare
785d0fe
to
5a2574f
Compare
Update templates in instances.yaml
And in order to reduce visual bloat on the markdown table, the notes and the modfiied column are merged together
bd2aead
to
3a95c88
Compare
This is an alternative take on #74 that automates everything.
Preview: https://github.com/syeopite/documentation/blob/alt-instance-list/Invidious-Instances.md
The Instance list is now defined in
instances.yaml
. When a PR is made that edits that file, GH actions would run and automatically generate the markdown version of the list through a python script.The data and design (markdown result) from this PR is mostly taken from #74 as well