fix: improve error handling in task queue #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change modifies the #enqueue method to handle both resolution and rejection with the same task function, enabling error recovery by retrying failed tasks instead of propagating errors. A comprehensive test was added to validate the issue and then that the fix passes the test suite. This verifies that the client continues working properly after encountering errors.
iuioiua
approved these changes
Dec 2, 2025
Owner
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
Nice fix! I used assertRejects to assert that redisClient.sendCommand rejects in the desired manner.
iuioiua
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change modifies the #enqueue method to handle both resolution and rejection with the same task function, enabling error recovery by retrying failed tasks instead of propagating errors. A comprehensive test was added to validate the issue and then that the fix passes the test suite. This verifies that the client continues working properly after encountering errors.
This fixes #23