Add caching to UserActivity#value

itkpi · Jul 23, 2017 · 5bea1b0 · 5bea1b0
1 parent 3fe38f7
commit 5bea1b0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb
@@ -3,7 +3,6 @@ class DashboardController < ApplicationController
   before_action :require_room_presence
 
   def index
-    @room = Room.includes(:users, room_actions: :user_actions).where(id: current_user.room_id).first
     # TODO: get array of activities
     # @activities = @room.activities
   end

diff --git a/app/models/user_activity.rb b/app/models/user_activity.rb
@@ -13,6 +13,6 @@ def activities
   end
 
   def value
-    activities.count
+    @value ||= activities.count
   end
 end
diff --git a/spec/features/dashboard_spec.rb b/spec/features/dashboard_spec.rb
@@ -16,7 +16,7 @@
     }.to change { Activity.count }.by(1)
 
     expect(page).to have_content 'Good job'
-    expect(user.next_on_room_activities.pluck(:name)).not_to include(room_activity_name)
+    expect(user.reload.next_on_room_activities.pluck(:name)).not_to include(room_activity_name)
 
     # TODO: turn on this test, it is temporary disabled
     # click_on 'History'