Test custom exit #463
Merged
Test custom exit #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive parametrized test for the custom_exit function in the NostalgiaForInfinityX5 strategy, ensuring that the correct exit functions are called based on the trade's enter_tag. The test covers both long and short entry tags, including individual and combined scenarios, and uses mocked exit functions to validate behavior. Known issues with certain short entry tags, such as short_exit_grind, are identified and marked as TODO for future fixes. This test enhances the robustness of the strategy by providing a clear framework to detect regressions and verify the correctness of exit logic.