Added a --resume-file argument to butler extract #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the ability to interrupt downloads part way through using a lot of existing features in the stack. itchio/hush provides an intervalSaveConsumer that can store the results of a partial extraction. And itchio/savior can use this as part of the normal extraction. My code conditionally creates a saveConsumer if the --resume-file argument is provided and gives it to the extractor instead of a nil checkpoint to ex.Resume() I haven't worked with golang before, but I compiled a local version of butler that seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to interrupt and resume extractions part way through using a lot of existing features in the stack. itchio/hush provides an intervalSaveConsumer that can store the results of a partial extraction. And itchio/savior can use this as part of the normal extraction.
My code conditionally creates a saveConsumer if the --resume-file argument is provided and gives it to the extractor instead of a nil checkpoint to ex.Resume()
I haven't worked with golang before, but I compiled a local version of butler and used it with success.