Merge pull request #55 from italia/CI

fix: spid-sp-test exit code in CI
italia · Jun 14, 2021 · 03e4127 · 03e4127
2 parents 99aec14 + 505a446
commit 03e4127
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml
@@ -68,7 +68,7 @@ jobs:
         ./manage.py migrate > /dev/null 2>&1
         ./manage.py runserver > /dev/null 2>&1 &
         sleep 5
-        spid_sp_test --metadata-url http://localhost:8000/spid/metadata/ --authn-url http://localhost:8000/spid/login/?idp=http://localhost:8080 --extra --exit-zero --debug ERROR -tr
+        spid_sp_test --metadata-url http://localhost:8000/spid/metadata/ --authn-url http://localhost:8000/spid/login/?idp=http://localhost:8080 --extra --debug ERROR -tr
     - name: Test Django reusable app
       working-directory: .
       run: |

diff --git a/src/djangosaml2_spid/views.py b/src/djangosaml2_spid/views.py
@@ -325,11 +325,13 @@ def custom_validation(self, response):
         accepted_time_diff = conf.accepted_time_diff
         recipient = conf._sp_endpoints['assertion_consumer_service'][0][0]
         authn_context_classref = settings.SPID_AUTH_CONTEXT
-
+        
         in_response_to = ''
         oq_cache = OutstandingQueriesCache(self.request.saml_session)
+        logger.debug("Cache queries: {}".format(oq_cache.outstanding_queries()))
         for key, _value in oq_cache.outstanding_queries().items():
-            in_response_to = key  # FIXME?: filtering by _value??
+            in_response_to = key
+            logger.debug("in_response_to={!r}".format(in_response_to))
             break
 
         validator = Saml2ResponseValidator(authn_response=response.xmlstr,