bug/dispatch fix tagging with empty values

[simonhir]

Description

Dispatch fix tagging with empty values.
Implement workaround because Minio handles empty tags as null instead of empty string.

Reference

Issue minio/minio-java#1634

Summary by CodeRabbit

• Bug Fixes
  • Improved file metadata processing by ensuring missing tag values are seamlessly converted to empty strings for a more reliable display.

[coderabbitai]

Walkthrough

The pull request modifies the getTagsOfFile method in the S3Adapter class. The method now processes the tags retrieved from the Minio client by replacing any null values with empty strings. The overall logic for retrieving tags remains unchanged, and there are no modifications to error handling or public declarations.

Changes

File	Change Summary
dispatch-service/.../S3Adapter.java	Modified getTagsOfFile method: retrieves tags into a variable and replaces null values with empty strings; error handling remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Caller
    participant Adapter as S3Adapter
    participant Minio as MinioClient

    Client->>Adapter: Call getTagsOfFile()
    Adapter->>Minio: getObjectTags(getObjectTagsArgs)
    Minio-->>Adapter: Return tags (map, may contain null values)
    Adapter->>Adapter: Process tags (replace null with "")
    Adapter->>Client: Return processed tags

Loading

Poem

Oh, I hop with glee, a rabbit so bright,
Munching on code carrots all day and night.
Tags get cleaned, no null out of sight,
Changing with grace, the code feels light.
Hoppy improvements, a digital delight!
🐰🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 28a6314 and 7243226.

📒 Files selected for processing (1)

• dispatch-service/src/main/java/de/muenchen/oss/swim/dispatcher/adapter/out/s3/S3Adapter.java (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28a6314 and e350662.

📒 Files selected for processing (1)

• dispatch-service/src/main/java/de/muenchen/oss/swim/dispatcher/adapter/out/s3/S3Adapter.java (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: build all

dispatch-service/src/main/java/de/muenchen/oss/swim/dispatcher/adapter/out/s3/S3Adapter.java

[error] 329-329: The following files had format violations: Run 'mvn spotless:apply' to fix these violations.

🔇 Additional comments (1)

dispatch-service/src/main/java/de/muenchen/oss/swim/dispatcher/adapter/out/s3/S3Adapter.java (1)

326-333:

Details

✅ Verification successful

Good implementation of the null-to-empty-string conversion for tag values.

The code properly addresses the issue with Minio treating empty tags as null instead of empty strings. By converting any null values to empty strings, you ensure consistent behavior in the application.

---

🏁 Script executed:

#!/bin/bash
# Check if there are other places in the codebase that might need similar null handling for Minio tags
rg -A 5 -B 5 "minioClient\.getObjectTags" --type java

# Look for potential references to the Minio issue mentioned in the PR
rg "empty tags" --type java

Length of output: 1795

---

Null-to-Empty Tag Conversion Verified

The implementation correctly converts null tag values to empty strings, addressing the Minio behavior around empty tags. Our verification confirms that this handling is only applied in dispatch-service/src/main/java/de/muenchen/oss/swim/dispatcher/adapter/out/s3/S3Adapter.java and that similar logic isn’t required elsewhere. The code is robust and no further modifications are needed.

🧰 Tools

🪛 GitHub Actions: build all

[error] 329-329: The following files had format violations: Run 'mvn spotless:apply' to fix these violations.