Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test change to ensure mergify is working. #976

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Test change to ensure mergify is working. #976

merged 1 commit into from
Jul 12, 2019

Conversation

geeknoid
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 12, 2019
@geeknoid
Copy link
Contributor Author

Could someone approve this? I'm just trying to see if mergify works as expected.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geeknoid, howardjohn
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 5cf4c93 into istio:master Jul 12, 2019
@geeknoid
Copy link
Contributor Author

@howardjohn Thanks for approving. But you're not in the code owners file, so how come this was merged? Hmmm.

@howardjohn
Copy link
Member

howardjohn commented Jul 12, 2019 •
edited
Loading

My understanding is that mergify doesn't care about codeowners. If you have branch protection set up "right" (I am not sure what right is.. installer was this way as of this morning, may not now) it will get blocked, but not gracefully. See Mergifyio/mergify#448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@ozevren ozevren Awaiting requested review from ozevren

@andraxylia andraxylia Awaiting requested review from andraxylia

@costinm costinm Awaiting requested review from costinm

@mandarjog mandarjog Awaiting requested review from mandarjog

Assignees

@howardjohn howardjohn

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geeknoid @istio-testing @howardjohn @googlebot