Skip to content

improve documentation for tag and rev label #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve documentation for tag and rev label #3418

wants to merge 2 commits into from
+28 −20

Conversation

therealmitchconnors
Copy link
Contributor

As far as I know, this reflects the current state of these APIs. I'm not sure how this got so out of date...

@therealmitchconnors therealmitchconnors requested a review from a team as a code owner January 17, 2025 23:10
@istio-policy-bot
Copy link

😊 Welcome @therealmitchconnors! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@therealmitchconnors therealmitchconnors added the release-notes-none Indicates a PR that does not require release notes. label Jan 21, 2025
howardjohn
howardjohn reviewed Jan 22, 2025
View reviewed changes
label/labels.yaml
hidden: false
deprecated: false
resources:
- Namespace
- Gateway
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we may want to start disambiguating between k8s GW and Istio GW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but in this case, I believe this works with istio or k8s gateways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do Istio Gateway resources take tags into account at all? My understanding is that you'd need to label the deployment or pod

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Sep 5, 2025
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@keithmattix keithmattix keithmattix left review comments

@costinm costinm costinm approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@therealmitchconnors @istio-policy-bot @istio-testing @costinm @howardjohn @keithmattix