Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pod-level opt-out for ambient DNS proxying, in preparation for enabling that by default globally #3361

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+32 −0
Open

Add a pod-level opt-out for ambient DNS proxying, in preparation for enabling that by default globally #3361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbcf8df
Add a pod-level opt-out for ambient DNS proxying, in preparation for …
bleggett Nov 14, 2024
a81bded
Add relnote
bleggett Nov 14, 2024
79a4db5
Change to `ambient.istio.io/dns-capture` as per review comments
bleggett Dec 9, 2024
aa6324f
Wording tweak
bleggett Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions annotation/annotations.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions annotation/annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,3 +582,13 @@ annotations:
hidden: false
resources:
- Pod

- name: ambient.istio.io/dns-capture
featureStatus: Alpha
description: |
When specified on a `Pod` enrolled in ambient mesh, controls whether DNS traffic (TCP and UDP on port 53) will be captured and proxied in ambient.
Note that setting this to `false` will break some Istio features, such as ServiceEntries and egress waypoints, but may be desirable for workloads that interact poorly with DNS proxies.
deprecated: false
hidden: true
resources:
- Pod
8 changes: 8 additions & 0 deletions releasenotes/notes/3361.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: release-notes/v2
kind: feature
area: traffic-management
issue:
- 49829
releaseNotes:
- |
**Added** `ambient.istio.io/bypass-dns-capture` annotation. When specified on a `Pod` enrolled in ambient mesh, DNS traffic (TCP and UDP on port 53) will not be captured or proxied. This will break some Istio features, such as ServiceEntries and egress waypoints, but may be desirable for workloads that interact poorly with DNS proxies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note is stale