Skip to content

Commit

Permalink
remove proto annotations of 'name' based on comment
Browse files Browse the repository at this point in the history
  • Loading branch information
zhlsunshine committed Dec 9, 2021
1 parent ab0c817 commit 017048a
Show file tree
Hide file tree
Showing 22 changed files with 857 additions and 987 deletions.
141 changes: 23 additions & 118 deletions common-protos/istio.io/extensions/field_feature.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions common-protos/istio.io/extensions/field_feature.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions common-protos/istio.io/extensions/field_feature.proto
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,7 @@ message IstioFeature {
// label the feature's status, available status values may be alpha, beta and stable
// there would be experimental in future.
optional FeatureStatus status = 1;
// show the feature field for specified resource,
// such as "VirtualService.export_to" shows the virtualservice's field export_to,
// it can be defined by feature owner in the format of "MessageName.FieldName".
optional string name = 2;
// id means the feature id which can be mapped here: https://github.com/istio/enhancements/blob/master/features.yaml
// it should be contained in id section of features under this yaml file.
optional string id = 3;
optional string id = 2;
}
Loading

0 comments on commit 017048a

Please sign in to comment.