Cleanup experimental report flag. (dart-lang#8001)

isoos · Sep 2, 2024 · fe31b83 · fe31b83
1 parent b2394d4
commit fe31b83
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart
@@ -8,7 +8,6 @@ import '../../shared/cookie_utils.dart';
 
 const _publicFlags = <String>{
   'dark',
-  'report',
 };
 
 const _allFlags = <String>{
@@ -84,8 +83,6 @@ class ExperimentalFlags {
     return params;
   }
 
-  bool get isReportPageEnabled => true;
-
   bool get isDarkModeEnabled => isEnabled('dark');
   bool get isDarkModeDefault => isEnabled('dark-as-default');
 

diff --git a/app/lib/frontend/handlers/report.dart b/app/lib/frontend/handlers/report.dart
@@ -31,10 +31,6 @@ const _reportRateLimitWindowAsText = 'last 10 minutes';
 
 /// Handles GET /report
 Future<shelf.Response> reportPageHandler(shelf.Request request) async {
-  if (!requestContext.experimentalFlags.isReportPageEnabled) {
-    return notFoundHandler(request);
-  }
-
   final caseId = request.requestedUri.queryParameters['appeal'];
   final mc = await _loadAndVerifyCase(caseId);
 
@@ -136,10 +132,6 @@ Future<void> _verifyCaseSubject(
 /// Handles POST /api/report
 Future<String> processReportPageHandler(
     shelf.Request request, ReportForm form) async {
-  if (!requestContext.experimentalFlags.isReportPageEnabled) {
-    throw NotFoundException('Experimental flag is not enabled.');
-  }
-
   final sourceIp = request.sourceIp;
   if (sourceIp != null) {
     await verifyRequestCounts(

diff --git a/app/lib/frontend/templates/layout.dart b/app/lib/frontend/templates/layout.dart
@@ -65,9 +65,6 @@ String renderLayoutPage(
   final announcementBannerHtml = announcementBackend.getAnnouncementHtml();
   final session = requestContext.sessionData;
   final moderationSubject = () {
-    if (!requestContext.experimentalFlags.isReportPageEnabled) {
-      return null;
-    }
     if (pageData == null) {
       return null;
     }