Remove pkg/_popularity + update CI (dart-lang#8464)

.github/workflows/dart.yml

@@ -40,16 +40,16 @@ jobs:
       - name: mono_repo self validate
         run: dart pub global run mono_repo generate --validate
   job_002:
-    name: "smoke_test; PKGS: app, pkg/_popularity, pkg/_pub_shared, pkg/api_builder, pkg/fake_gcloud, pkg/pub_package_reader, pkg/web_app, pkg/web_css; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos  .`"
+    name: "smoke_test; PKGS: app, pkg/_pub_shared, pkg/api_builder, pkg/fake_gcloud, pkg/pub_package_reader, pkg/web_app, pkg/web_css; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos  .`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:app-pkg/_popularity-pkg/_pub_shared-pkg/api_builder-pkg/fake_gcloud-pkg/pub_package_reader-pkg/web_app-pkg/web_css;commands:format-analyze_0"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:app-pkg/_pub_shared-pkg/api_builder-pkg/fake_gcloud-pkg/pub_package_reader-pkg/web_app-pkg/web_css;commands:format-analyze_0"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:app-pkg/_popularity-pkg/_pub_shared-pkg/api_builder-pkg/fake_gcloud-pkg/pub_package_reader-pkg/web_app-pkg/web_css
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:app-pkg/_pub_shared-pkg/api_builder-pkg/fake_gcloud-pkg/pub_package_reader-pkg/web_app-pkg/web_css
             os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
@@ -73,19 +73,6 @@ jobs:
         run: dart analyze --fatal-infos  .
         if: "always() && steps.app_pub_get.conclusion == 'success'"
         working-directory: app
-      - id: pkg__popularity_pub_get
-        name: pkg/_popularity; dart pub get
-        run: dart pub get
-        if: "always() && steps.checkout.conclusion == 'success'"
-        working-directory: pkg/_popularity
-      - name: "pkg/_popularity; dart format --output=none --set-exit-if-changed ."
-        run: "dart format --output=none --set-exit-if-changed ."
-        if: "always() && steps.pkg__popularity_pub_get.conclusion == 'success'"
-        working-directory: pkg/_popularity
-      - name: "pkg/_popularity; dart analyze --fatal-infos  ."
-        run: dart analyze --fatal-infos  .
-        if: "always() && steps.pkg__popularity_pub_get.conclusion == 'success'"
-        working-directory: pkg/_popularity
       - id: pkg__pub_shared_pub_get
         name: pkg/_pub_shared; dart pub get
         run: dart pub get
@@ -729,45 +716,6 @@ jobs:
       - job_007
       - job_008
   job_017:
-    name: "unit_test; PKG: pkg/_popularity; `dart test --run-skipped`"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Cache Pub hosted dependencies
-        uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2
-        with:
-          path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:pkg/_popularity;commands:test_09"
-          restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:pkg/_popularity
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
-            os:ubuntu-latest;pub-cache-hosted
-            os:ubuntu-latest
-      - name: Setup Dart SDK
-        uses: dart-lang/setup-dart@f0ead981b4d9a35b37f30d36160575d60931ec30
-        with:
-          sdk: "3.6.0"
-      - id: checkout
-        name: Checkout repository
-        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
-      - id: pkg__popularity_pub_get
-        name: pkg/_popularity; dart pub get
-        run: dart pub get
-        if: "always() && steps.checkout.conclusion == 'success'"
-        working-directory: pkg/_popularity
-      - name: "pkg/_popularity; dart test --run-skipped"
-        run: dart test --run-skipped
-        if: "always() && steps.pkg__popularity_pub_get.conclusion == 'success'"
-        working-directory: pkg/_popularity
-    needs:
-      - job_001
-      - job_002
-      - job_003
-      - job_004
-      - job_005
-      - job_006
-      - job_007
-      - job_008
-  job_018:
     name: "unit_test; PKG: pkg/_pub_shared; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
@@ -806,7 +754,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_019:
+  job_018:
     name: "unit_test; PKG: pkg/fake_gcloud; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
@@ -845,7 +793,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_020:
+  job_019:
     name: "unit_test; PKG: pkg/indexed_blob; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
@@ -884,7 +832,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_021:
+  job_020:
     name: "unit_test; PKG: pkg/pub_package_reader; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
@@ -923,7 +871,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_022:
+  job_021:
     name: "unit_test; PKG: pkg/web_app; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
@@ -962,7 +910,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_023:
+  job_022:
     name: "unit_test; PKG: pkg/web_css; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
@@ -1001,7 +949,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_024:
+  job_023:
     name: "unit_test; PKG: pkg/pub_integration; `dart test -j1 --run-skipped `find test -name \"*_test\\\\.dart\" | sort | sed -n '0~4p'``"
     runs-on: ubuntu-latest
     steps:
@@ -1040,7 +988,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_025:
+  job_024:
     name: "unit_test; PKG: pkg/pub_integration; `dart test -j1 --run-skipped `find test -name \"*_test\\\\.dart\" | sort | sed -n '1~4p'``"
     runs-on: ubuntu-latest
     steps:
@@ -1079,7 +1027,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_026:
+  job_025:
     name: "unit_test; PKG: pkg/pub_integration; `dart test -j1 --run-skipped `find test -name \"*_test\\\\.dart\" | sort | sed -n '2~4p'``"
     runs-on: ubuntu-latest
     steps:
@@ -1118,7 +1066,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_027:
+  job_026:
     name: "unit_test; PKG: pkg/pub_integration; `dart test -j1 --run-skipped `find test -name \"*_test\\\\.dart\" | sort | sed -n '3~4p'``"
     runs-on: ubuntu-latest
     steps:
@@ -1157,7 +1105,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_028:
+  job_027:
     name: "unit_test; PKG: pkg/pub_worker; `dart test --run-skipped --concurrency=1 `find test -name \"*_test\\\\.dart\" | sort | sed -n '0~3p'``"
     runs-on: ubuntu-latest
     steps:
@@ -1196,7 +1144,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_029:
+  job_028:
     name: "unit_test; PKG: pkg/pub_worker; `dart test --run-skipped --concurrency=1 `find test -name \"*_test\\\\.dart\" | sort | sed -n '1~3p'``"
     runs-on: ubuntu-latest
     steps:
@@ -1235,7 +1183,7 @@ jobs:
       - job_006
       - job_007
       - job_008
-  job_030:
+  job_029:
     name: "unit_test; PKG: pkg/pub_worker; `dart test --run-skipped --concurrency=1 `find test -name \"*_test\\\\.dart\" | sort | sed -n '2~3p'``"
     runs-on: ubuntu-latest
     steps:

app/pubspec.yaml

@@ -4,7 +4,6 @@ environment:
   sdk: ^3.6.0
 resolution: workspace
 dependencies:
-  _popularity:
   _pub_shared:
   appengine: ^0.13.8
   args: '^2.0.0'