Skip to content

Commit

Permalink
Draw edges of sparkline chart area (dart-lang#8286)
Browse files Browse the repository at this point in the history
  • Loading branch information
szakarias authored Nov 14, 2024
1 parent ce6193b commit b8f3046
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/web_app/lib/src/widget/weekly_sparkline/widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ void drawChart(Element svg, HTMLDivElement toolTip, HTMLDivElement chartSubText,
area.setAttribute(
'd', '$line L${drawingWidth + padding} $height L$padding $height Z');

chart.append(sparkline);
chart.append(area);
chart.append(sparkline);

svg.append(chart);

Expand Down
3 changes: 2 additions & 1 deletion pkg/web_css/lib/src/_detail_page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,10 @@ $detail-tabs-tablet-width: calc(100% - 240px);
}

.weekly-sparkline-area {
stroke: var(--pub-weekly-chart-main-color);
fill: var(--pub-weekly-chart-main-color);
opacity: 0.3;
stroke-width: 0;
stroke-width: 2;
}

@media (min-width: $device-desktop-min-width) {
Expand Down

0 comments on commit b8f3046

Please sign in to comment.