Missing tooltips for versions link on package page. (dart-lang#7346)

isoos · Jan 18, 2024 · 9995601 · 9995601
1 parent e588d98
commit 9995601
Show file tree

Hide file tree

Showing 27 changed files with 74 additions and 57 deletions.
diff --git a/app/lib/frontend/templates/views/pkg/header.dart b/app/lib/frontend/templates/views/pkg/header.dart
@@ -54,20 +54,24 @@ List<d.Node> _releases(String package, LatestReleases releases) {
       child: d.a(
         href: urls.pkgPageUrl(package),
         text: releases.stable.version,
+        title: 'View the latest version of $package',
       ),
     ),
     if (releases.showPreview)
       ..._versionLink(
         package: package,
         version: releases.preview!.version,
         label: 'Preview',
-        title: 'Preview is a stable version that depends on a prerelease SDK.',
+        spanTitle:
+            'Preview is a stable version that depends on a prerelease SDK.',
+        linkTitle: 'Visit $package ${releases.preview!.version} page',
       ),
     if (releases.showPrerelease)
       ..._versionLink(
         package: package,
         version: releases.prerelease!.version,
         label: 'Prerelease',
+        linkTitle: 'Visit $package ${releases.prerelease!.version} page',
       ),
   ];
 }
@@ -76,15 +80,20 @@ List<d.Node> _versionLink({
   required String package,
   required String version,
   required String label,
-  String? title,
+  String? spanTitle,
+  required String linkTitle,
 }) {
   return [
     d.text(' / '),
     d.span(
-      attributes: title != null ? {'title': title} : null,
+      attributes: spanTitle != null ? {'title': spanTitle} : null,
       children: [
         d.text('$label: '),
-        d.a(href: urls.pkgPageUrl(package, version: version), text: version),
+        d.a(
+          href: urls.pkgPageUrl(package, version: version),
+          text: version,
+          title: linkTitle,
+        ),
       ],
     ),
   ];

diff --git a/app/lib/frontend/templates/views/pkg/package_list.dart b/app/lib/frontend/templates/views/pkg/package_list.dart
@@ -89,6 +89,7 @@ d.Node _packageItem(
           version: isLatest ? null : release.version,
         ),
         text: release.version,
+        title: 'Visit ${view.name} ${release.version} page',
       ),
       d.text(' ('),
       d.xAgoTimestamp(release.published),

diff --git a/app/lib/frontend/templates/views/pkg/versions/version_row.dart b/app/lib/frontend/templates/views/pkg/versions/version_row.dart
@@ -28,6 +28,7 @@ d.Node versionRowNode(
         child: d.a(
           href: urls.pkgPageUrl(package, version: version.version),
           text: version.version,
+          title: 'Visit $package ${version.version} page',
         ),
       ),
       d.td(

diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html
@@ -222,11 +222,11 @@ <h3 class="packages-title">
                           <p class="packages-metadata">
                             <span class="packages-metadata-block">
                               v
-                              <a href="/packages/oxygen">1.2.0</a>
+                              <a href="/packages/oxygen" title="Visit oxygen 1.2.0 page">1.2.0</a>
                               (
                               <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               ) /
-                              <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                              <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                               (
                               <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               )
@@ -298,7 +298,7 @@ <h3 class="packages-title">
                           <p class="packages-metadata">
                             <span class="packages-metadata-block">
                               v
-                              <a href="/packages/neon">1.0.0</a>
+                              <a href="/packages/neon" title="Visit neon 1.0.0 page">1.0.0</a>
                               (
                               <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               )

diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html
@@ -156,12 +156,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html
@@ -156,12 +156,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_index_page.html b/app/test/frontend/golden/pkg_index_page.html
@@ -472,11 +472,11 @@ <h3 class="packages-title">
                   <p class="packages-metadata">
                     <span class="packages-metadata-block">
                       v
-                      <a href="/packages/oxygen">1.2.0</a>
+                      <a href="/packages/oxygen" title="Visit oxygen 1.2.0 page">1.2.0</a>
                       (
                       <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                       ) /
-                      <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                      <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                       (
                       <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                       )
@@ -548,7 +548,7 @@ <h3 class="packages-title">
                   <p class="packages-metadata">
                     <span class="packages-metadata-block">
                       v
-                      <a href="/packages/flutter_titanium">1.10.0</a>
+                      <a href="/packages/flutter_titanium" title="Visit flutter_titanium 1.10.0 page">1.10.0</a>
                       (
                       <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                       )

diff --git a/app/test/frontend/golden/pkg_install_page.html b/app/test/frontend/golden/pkg_install_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_score_page.html b/app/test/frontend/golden/pkg_score_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_show_page.html b/app/test/frontend/golden/pkg_show_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_show_page_retracted.html b/app/test/frontend/golden/pkg_show_page_retracted.html
@@ -130,7 +130,7 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/pkg">2.0.0</a>
+                    <a href="/packages/pkg" title="View the latest version of pkg">2.0.0</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_show_version_page.html b/app/test/frontend/golden/pkg_show_version_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">

diff --git a/app/test/frontend/golden/pkg_versions_page.html b/app/test/frontend/golden/pkg_versions_page.html
@@ -130,12 +130,12 @@ <h1 class="title">
                   </span>
                   • Latest:
                   <span>
-                    <a href="/packages/oxygen">1.2.0</a>
+                    <a href="/packages/oxygen" title="View the latest version of oxygen">1.2.0</a>
                   </span>
                   /
                   <span>
                     Prerelease:
-                    <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                    <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                   </span>
                 </div>
                 <div class="detail-tags-and-like">
@@ -237,7 +237,7 @@ <h2 id="stable">Stable versions of oxygen</h2>
                     <tbody>
                       <tr data-version="1.2.0">
                         <td class="version">
-                          <a href="/packages/oxygen/versions/1.2.0">1.2.0</a>
+                          <a href="/packages/oxygen/versions/1.2.0" title="Visit oxygen 1.2.0 page">1.2.0</a>
                         </td>
                         <td class="badge">
                           <span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
@@ -259,7 +259,7 @@ <h2 id="stable">Stable versions of oxygen</h2>
                       </tr>
                       <tr data-version="1.0.0">
                         <td class="version">
-                          <a href="/packages/oxygen/versions/1.0.0">1.0.0</a>
+                          <a href="/packages/oxygen/versions/1.0.0" title="Visit oxygen 1.0.0 page">1.0.0</a>
                         </td>
                         <td class="badge">
                           <span class="package-badge" title="Package version is opted into null safety.">Null safety</span>
@@ -300,7 +300,7 @@ <h2 id="prerelease">Prerelease versions of oxygen</h2>
                     <tbody>
                       <tr data-version="2.0.0-dev">
                         <td class="version">
-                          <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                          <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                         </td>
                         <td class="badge">
                           <span class="package-badge" title="Package version is opted into null safety.">Null safety</span>

diff --git a/app/test/frontend/golden/publisher_packages_page.html b/app/test/frontend/golden/publisher_packages_page.html
@@ -224,7 +224,7 @@ <h3 class="packages-title">
                           <p class="packages-metadata">
                             <span class="packages-metadata-block">
                               v
-                              <a href="/packages/neon">1.0.0</a>
+                              <a href="/packages/neon" title="Visit neon 1.0.0 page">1.0.0</a>
                               (
                               <a class="-x-ago" href="" title="%%neon-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               )
@@ -298,7 +298,7 @@ <h3 class="packages-title">
                           <p class="packages-metadata">
                             <span class="packages-metadata-block">
                               v
-                              <a href="/packages/flutter_titanium">1.10.0</a>
+                              <a href="/packages/flutter_titanium" title="Visit flutter_titanium 1.10.0 page">1.10.0</a>
                               (
                               <a class="-x-ago" href="" title="%%neon-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               )

diff --git a/app/test/frontend/golden/publisher_unlisted_packages_page.html b/app/test/frontend/golden/publisher_unlisted_packages_page.html
@@ -230,7 +230,7 @@ <h3 class="packages-title">
                           <p class="packages-metadata">
                             <span class="packages-metadata-block">
                               v
-                              <a href="/packages/neon">1.0.0</a>
+                              <a href="/packages/neon" title="Visit neon 1.0.0 page">1.0.0</a>
                               (
                               <a class="-x-ago" href="" title="%%neon-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               )
@@ -304,7 +304,7 @@ <h3 class="packages-title">
                           <p class="packages-metadata">
                             <span class="packages-metadata-block">
                               v
-                              <a href="/packages/flutter_titanium">1.10.0</a>
+                              <a href="/packages/flutter_titanium" title="Visit flutter_titanium 1.10.0 page">1.10.0</a>
                               (
                               <a class="-x-ago" href="" title="%%neon-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                               )

diff --git a/app/test/frontend/golden/search_page.html b/app/test/frontend/golden/search_page.html
@@ -454,11 +454,11 @@ <h3 class="packages-title">
                   <p class="packages-metadata">
                     <span class="packages-metadata-block">
                       v
-                      <a href="/packages/oxygen">1.2.0</a>
+                      <a href="/packages/oxygen" title="Visit oxygen 1.2.0 page">1.2.0</a>
                       (
                       <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                       ) /
-                      <a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>
+                      <a href="/packages/oxygen/versions/2.0.0-dev" title="Visit oxygen 2.0.0-dev page">2.0.0-dev</a>
                       (
                       <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                       )
@@ -541,7 +541,7 @@ <h3 class="packages-title">
                   <p class="packages-metadata">
                     <span class="packages-metadata-block">
                       v
-                      <a href="/packages/flutter_titanium">1.10.0</a>
+                      <a href="/packages/flutter_titanium" title="Visit flutter_titanium 1.10.0 page">1.10.0</a>
                       (
                       <a class="-x-ago" href="" title="%%oxygen-created-date%%" aria-label="%%x-ago%%" aria-role="button" role="button" data-timestamp="%%millis%%">%%x-ago%%</a>
                       )

diff --git a/app/test/frontend/handlers/package_test.dart b/app/test/frontend/handlers/package_test.dart
@@ -18,8 +18,9 @@ void main() {
         await issueGet('/packages/oxygen'),
         present: [
           'oxygen 1.2.0',
-          '<a href="/packages/oxygen">1.2.0</a>',
-          '<a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>',
+          RegExp(r'<a href="/packages/oxygen" title=".*">1.2.0</a>'),
+          RegExp(
+              r'<a href="/packages/oxygen/versions/2.0.0-dev" title=".*">2.0.0-dev</a>'),
         ],
         absent: [
           'data-name="-admin-tab-"',
@@ -50,8 +51,9 @@ void main() {
         await issueGet('/packages/oxygen/versions'),
         present: [
           'oxygen 1.2.0',
-          '<a href="/packages/oxygen">1.2.0</a>',
-          '<a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>',
+          RegExp(r'<a href="/packages/oxygen" title=".*">1.2.0</a>'),
+          RegExp(
+              r'<a href="/packages/oxygen/versions/2.0.0-dev" title=".*">2.0.0-dev</a>'),
         ],
       );
     });
@@ -69,8 +71,9 @@ void main() {
         await issueGet('/packages/oxygen/versions/1.0.0'),
         present: [
           'oxygen 1.0.0',
-          '<a href="/packages/oxygen">1.2.0</a>',
-          '<a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>',
+          RegExp(r'<a href="/packages/oxygen" title=".*">1.2.0</a>'),
+          RegExp(
+              r'<a href="/packages/oxygen/versions/2.0.0-dev" title=".*">2.0.0-dev</a>'),
         ],
       );
     });
@@ -81,8 +84,9 @@ void main() {
         await issueGet('/packages/oxygen/versions/2.0.0%2Ddev'),
         present: [
           'oxygen 2.0.0-dev',
-          '<a href="/packages/oxygen">1.2.0</a>',
-          '<a href="/packages/oxygen/versions/2.0.0-dev">2.0.0-dev</a>',
+          RegExp(r'<a href="/packages/oxygen" title=".*">1.2.0</a>'),
+          RegExp(
+              r'<a href="/packages/oxygen/versions/2.0.0-dev" title=".*">2.0.0-dev</a>'),
         ],
       );
     });