Skip to content

Commit

Permalink
Upgrade dartdoc to 8.0.3 (dart-lang#7368)
Browse files Browse the repository at this point in the history
  • Loading branch information
isoos authored Jan 9, 2024
1 parent efef08f commit 23a9271
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ Important changes to data models, configuration, and migrations between each
AppEngine version, listed here to ease deployment and troubleshooting.

## Next Release (replace with git tag when deployed)
* Bumped runtimeVersion to `2024.01.09`.
* Upgraded dartdoc to `8.0.3`.

## `20240102t140400-all`
* Bumped runtimeVersion to `2023.12.18`.
Expand Down
8 changes: 4 additions & 4 deletions app/lib/shared/versions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ final RegExp runtimeVersionPattern = RegExp(r'^\d{4}\.\d{2}\.\d{2}$');
/// when the version switch happens.
const _acceptedRuntimeVersions = <String>[
// The current [runtimeVersion].
'2023.12.18',
'2024.01.09',
// Fallback runtime versions.
'2023.12.18',
'2023.12.08',
'2023.11.28',
];

/// Sets the current runtime versions.
Expand Down Expand Up @@ -75,5 +75,5 @@ final semanticToolStableFlutterSdkVersion =
// Value comes from package:pana.
final String panaVersion = pana.packageVersion;

// keep in-sync with pkg/pub_dartdoc/pubspec.yaml
final String dartdocVersion = '8.0.0';
// keep in-sync with pkg/pub-worker/lib/src/bin/pana_wrapper.dart
final String dartdocVersion = '8.0.3';
3 changes: 2 additions & 1 deletion pkg/pub_worker/lib/src/bin/pana_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ Future<void> main(List<String> args) async {
if (configDir != null) 'XDG_CONFIG_HOME': configDir,
},
useGlobalDartdoc: true,
globalDartdocVersion: '8.0.0',
// keep in-sync with app/lib/shared/versions.dart
globalDartdocVersion: '8.0.3',
);

//final dartdocOutputDir =
Expand Down
3 changes: 1 addition & 2 deletions third_party/dartdoc/resources/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ main {
flex: 1;
display: flex;
flex-direction: row;
padding: 20px;
min-height: 0;
}

Expand Down Expand Up @@ -1197,4 +1196,4 @@ li.inherited a {
a[href]:after {
content: "" !important;
}
}
}

0 comments on commit 23a9271

Please sign in to comment.