Replace search icon: button -> span. (dart-lang#7262)

isoos · Dec 7, 2023 · 06db9bd · 06db9bd
1 parent 2ec614c
commit 06db9bd
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 10 deletions.
diff --git a/app/lib/frontend/templates/views/shared/search_banner.dart b/app/lib/frontend/templates/views/shared/search_banner.dart
@@ -30,7 +30,7 @@ d.Node searchBannerNode({
           'aria-label': 'Search',
         },
       ),
-      d.button(classes: ['icon'], ariaLabel: 'search'),
+      d.span(classes: ['icon']),
       if (showSearchFiltersButton)
         d.div(
           classes: [

diff --git a/app/test/frontend/golden/error_page.html b/app/test/frontend/golden/error_page.html
@@ -103,7 +103,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
         </form>
       </div>
     </div>

diff --git a/app/test/frontend/golden/landing_page.html b/app/test/frontend/golden/landing_page.html
@@ -105,7 +105,7 @@ <h2 class="_visuallyhidden">pub.dev package manager</h2>
         <img class="logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="328" height="70" role="presentation"/>
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
         </form>
         <p class="text">
           The official package repository for

diff --git a/app/test/frontend/golden/pkg_index_page.html b/app/test/frontend/golden/pkg_index_page.html
@@ -104,7 +104,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" value="sdk:dart" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
           <div class="search-filters-btn-wrapper -active">
             <img class="search-filters-btn search-filters-btn-inactive" src="/static/hash-%%etag%%/img/search-filters-inactive.svg" alt="icon to toggle the display of search filters (inactive)" width="42" height="42"/>
             <img class="search-filters-btn search-filters-btn-active" src="/static/hash-%%etag%%/img/search-filters-active.svg" alt="icon to toggle the display of search filters (active)" width="42" height="42"/>

diff --git a/app/test/frontend/golden/publisher_activity_log_page.html b/app/test/frontend/golden/publisher_activity_log_page.html
@@ -105,7 +105,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
         </form>
       </div>
     </div>

diff --git a/app/test/frontend/golden/publisher_admin_page.html b/app/test/frontend/golden/publisher_admin_page.html
@@ -105,7 +105,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
         </form>
       </div>
     </div>

diff --git a/app/test/frontend/golden/publisher_list_page.html b/app/test/frontend/golden/publisher_list_page.html
@@ -104,7 +104,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
           <div class="search-filters-btn-wrapper">
             <img class="search-filters-btn search-filters-btn-inactive" src="/static/hash-%%etag%%/img/search-filters-inactive.svg" alt="icon to toggle the display of search filters (inactive)" width="42" height="42"/>
             <img class="search-filters-btn search-filters-btn-active" src="/static/hash-%%etag%%/img/search-filters-active.svg" alt="icon to toggle the display of search filters (active)" width="42" height="42"/>

diff --git a/app/test/frontend/golden/publisher_packages_page.html b/app/test/frontend/golden/publisher_packages_page.html
@@ -105,7 +105,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
         </form>
       </div>
     </div>

diff --git a/app/test/frontend/golden/publisher_unlisted_packages_page.html b/app/test/frontend/golden/publisher_unlisted_packages_page.html
@@ -105,7 +105,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" autofocus="autofocus" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
         </form>
       </div>
     </div>

diff --git a/app/test/frontend/golden/search_page.html b/app/test/frontend/golden/search_page.html
@@ -104,7 +104,7 @@ <h3 class="foldable-button">
       <div class="container">
         <form class="search-bar banner-item" action="/packages">
           <input class="input" name="q" placeholder="Search packages" autocomplete="on" value="foobar" title="Search" aria-label="Search"/>
-          <button class="icon" aria-label="search"></button>
+          <span class="icon"></span>
           <div class="search-filters-btn-wrapper">
             <img class="search-filters-btn search-filters-btn-inactive" src="/static/hash-%%etag%%/img/search-filters-inactive.svg" alt="icon to toggle the display of search filters (inactive)" width="42" height="42"/>
             <img class="search-filters-btn search-filters-btn-active" src="/static/hash-%%etag%%/img/search-filters-active.svg" alt="icon to toggle the display of search filters (active)" width="42" height="42"/>