Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to LegoRaceCar and LegoJetski #1378

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

disinvite
Copy link
Collaborator

Corrects beta address for g_skBMap array.

Moved MxMatrix variable init position in HitActor functions to match beta. Removed timeElapsed variable per the beta.

Renamed global variables related to sounds and timed events. This was partly based on checking the actual files with SIEdit. I didn't check in the actual game so feel free to correct me if I'm wrong here. I'm basing the name g_playerHitStudsSounds on the fact that srt018sl through srt029sl are grunts and pain sounds. In contrast, srt006sl is "Eat my bricks buddy!" so this seems like a sound for when Studs hits you instead of you hitting him. Does this mean that the second bool parameter of all the HitActor functions tells whether the player is moving at the time of the collision? (As a way to tell who hit who)

Named the InitSoundIndices functions for both LegoRaceCar and LegoJetski

Removed the animMap variable and two string variables in LegoRaceCar::ParseAction per the beta. This is still 100%.

I think the accuracy dip in LegoJetski::HitActor is from entropy near the strcmpi calls.

@foxtacles
Copy link
Member

Does this mean that the second bool parameter of all the HitActor functions tells whether the player is moving at the time of the collision? (As a way to tell who hit who)

Yes I'm pretty sure. I've looked at that logic before and that seems to be what it is.

@disinvite disinvite merged commit 29bf588 into isledecomp:master Jan 27, 2025
12 checks passed
@disinvite disinvite deleted the legoracecar branch January 27, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants