support webpack #37
Open
support webpack #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc30
requested changes
Apr 22, 2018
src/WebLinq.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| import * as LinqCollection from "./Linq"; | |||
There was a problem hiding this comment.
no need for this file.
Webpack has the option to target UMD and it does this automatically
webpack.config.js
Outdated
| mode, | ||
| entry: { | ||
| "linq-collection": [ | ||
| './src/WebLinq.ts' |
There was a problem hiding this comment.
2 versions: node (commonjs) and web (umd)
webpack.config.js
Outdated
|
|
||
| module.exports = [ | ||
| getConfig("production", "bundle.min"), | ||
| getConfig("development", "bundle") |
package.json
Outdated
| "publish-node": "npm run node-compile", | ||
| "publish-web": "browserify ./src/Linq.ts -p [tsify] > ./build/src/linq.web.js", | ||
| "prepublish": "npm run node-compile" | ||
| "build-web": "webpack-cli", |
There was a problem hiding this comment.
"build-web" -> "build"
this is triggered by continuous integration service
There was a problem hiding this comment.
also, change "typings" and "main" to point dist/linq-collections.js
There was a problem hiding this comment.
we should include the whole "dist" folder to the repo (with the newest compiled version)
package.json
Outdated
| "exclude": [ | ||
| "build/test" | ||
| "**/*.test.ts", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.