Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hive_generator built value support #533

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Hive_generator built value support #533

wants to merge 22 commits into from

Commits on Jan 5, 2021

  1. hive_generator: Support Built codegen 

    * Implemented: Built values, BuiltLists, BuiltMaps and BuiltSets
reading and writing.
* TODO: EnumClass support
    @KalilDev
    KalilDev committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    beb9c7f View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. hive_generator: Implement EnumClassBuilder

    @KalilDev
    KalilDev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    731e6d8 View commit details
    Browse the repository at this point in the history

  2. hive_generator: Null aware toBuilder()

    @KalilDev
    KalilDev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    bec838e View commit details
    Browse the repository at this point in the history

  3. hive_generator: correctly deserialize null ... 

    built_collections
    @KalilDev
    KalilDev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a933b50 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. hive_generator: Refactor class_builder 

    * Separate logic into regular and built methods
* Expose cast, buildReadConstructor and convertWritableValue
* Will be used to separate into two classes
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    aa70ffb View commit details
    Browse the repository at this point in the history

  2. hive_generator: Refactor ClassBuilder 

    * Split the base behavior into _ClassBuilderBase and the built_value
behavior into ClassBuilder.
* I think this is less cluttered, as the built_value behavior will get
more complex with the support for custom Builder classes and @BuiltValue
annotation
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    1b17cf9 View commit details
    Browse the repository at this point in the history

  3. hive_generator: depend on built_value and built_collection 

    * We will need to use more type checkers, and this will get out of hand.
* Besides, this is an dev_dependency only, so it isnt that big of a deal
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    f32caa6 View commit details
    Browse the repository at this point in the history

  4. hive_generator: lookup the name from custom builders

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    7adf101 View commit details
    Browse the repository at this point in the history

  5. hive_generator: expose methods from generator

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    f6ffa2d View commit details
    Browse the repository at this point in the history

  6. hive_generator: lookup setters for custom builders

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    8fa51a9 View commit details
    Browse the repository at this point in the history

  7. hive_generator: implement nested and custom builders

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    9c223e7 View commit details
    Browse the repository at this point in the history

  8. hive_generator: fix _castBuiltCollection

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    a1ce47f View commit details
    Browse the repository at this point in the history

  9. hive_generator: Workaround edge case when... 

    builder is being generated
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    dbd9e2c View commit details
    Browse the repository at this point in the history

  10. hive_generator: remove debuug print 

    * well, this is embarassing...
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    84d624a View commit details
    Browse the repository at this point in the history

  11. hive_generator: add element to AdapterFIeld

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    55492ac View commit details
    Browse the repository at this point in the history

  12. hive_generator: expose castIterable and castMap

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    c22b39a View commit details
    Browse the repository at this point in the history

  13. hive_generator: Support nested built_collection read

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    2cc0141 View commit details
    Browse the repository at this point in the history

  14. hive_generator: Support nested built_collection write

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    c8be0e3 View commit details
    Browse the repository at this point in the history

  15. hive_generator: fix _castBuiltCollection

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    cab846a View commit details
    Browse the repository at this point in the history

  16. hive_generator: fix buildReadConstructor

    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    126ce0a View commit details
    Browse the repository at this point in the history

  17. hive_generator: basic nullability awareness 

    * Only for built_value classes for reducing the amount of generated code
to a reasonable level
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    ff1181e View commit details
    Browse the repository at this point in the history

  18. Revert "hive_generator: basic nullability awareness" 

    * bad idea to do rn.

This reverts commit ff1181e.
    @KalilDev
    KalilDev committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    5ecf4a6 View commit details
    Browse the repository at this point in the history