Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Sundered Isles Settlement Entity #387

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Added Sundered Isles Settlement Entity #387

merged 2 commits into from
Jul 8, 2024

Conversation

bloodynine
Copy link
Contributor

Added in a Settlement Entity for Sundered Isles.

zkat
zkat reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks a lot for taking the time to do this! I have a couple of comments related to cursed tables, since we don't want to support those quite yet, but this otherwise looks great!

src/entity/specs.ts Outdated Show resolved Hide resolved
src/entity/specs.ts Outdated Show resolved Hide resolved
@zkat
Copy link
Member

zkat commented Jul 8, 2024

looks like you also need to run prettier.

@zkat zkat merged commit 98dc9c4 into iron-vault-plugin:main Jul 8, 2024
3 checks passed
@zkat zkat added the feature New feature or request label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bloodynine @zkat @kewilsonfacts