Skip to content

Add Indonesian (ID) internationalization to IRON FISH Node App Wallet#309

Merged
danield9tqh merged 7 commits intoiron-fish:mainfrom
ykris45:patch-1
Aug 20, 2025
Merged

Add Indonesian (ID) internationalization to IRON FISH Node App Wallet#309
danield9tqh merged 7 commits intoiron-fish:mainfrom
ykris45:patch-1

Conversation

@ykris45
Copy link
Contributor

@ykris45 ykris45 commented Aug 4, 2025

I am Yulius Kurniawan Kristianto aka Chris45new from Indonesia, on this wonderful occassion,
I will propose to add Bahasa Indonesia as new language support on IRON FISH Node App Wallet.

Thank You
Best Regards
Chris

@danield9tqh
Copy link
Member

Hey @ykris45 I don't know Indonesian so I just used coding agent to review the translations. Please review each of these comments and let me know if the updated changes are accurate or not

  1. "Minimum Teman" → Should be "Minimum Peer" or "Minimum Rekan"
  2. "Kirim Aktif" → Should be "Kirim Aset" (Send Asset, not Send Active)
  3. "Bahasa Inggris" for Spanish → Should be "Spanyol"
  4. "A" for "To" → Should be "Ke" or "Kepada"
  5. "Urutan Pemblokiran" → Should be "Urutan Blok" (Block Sequence)
  6. "Terjadi kesalahan terjadi" → Remove duplicate: "Terjadi kesalahan"
  7. "Blokir Grafiti" → Should be "Grafiti Blok"
  8. "Aliran terkirim" → Should be "Urutan yang Dikirim"
  9. "Mandarin" → Should be "Cina" or "Tiongkok"
  10. "Transaksi Informasi" → Should be "Informasi Transaksi"
  11. "Aktif" (line 532) → Should be "Aset"
  12. "AKSES KE AKSES TERSEBUT" → Should be "AKSES KE AKUN TERSEBUT"
  13. "Pesanan" for "Sort by" → Should be "Urutkan berdasarkan"
  14. "Master Hash" → Should be "Hash Utama"
  15. JSON key "pesan" → Should be "message" (lines 824-834)
  16. "Maksimum rekan kerja" → Should be "Maksimum Peer"
  17. "Silakan mulai ulang node" → Should be "Atur ulang node"
  18. "32 bita" → Should be "32 byte"
  19. "{assets}" parameter → Should be "{asset}" (singular)

@ykris45
Copy link
Contributor Author

ykris45 commented Aug 5, 2025

done sir thank you for the corrections to my PR. could you recheck Mr @danield9tqh

@ykris45
Copy link
Contributor Author

ykris45 commented Aug 17, 2025

thank you sir for approve my PR. when it will merged to ironfish state?. @danield9tqh

@danield9tqh danield9tqh reopened this Aug 19, 2025
@danield9tqh
Copy link
Member

danield9tqh commented Aug 19, 2025

@ykris45 It looks like the build is failing

Run npm run build-check

ironfish-node-app@3.0.17 build-check
npm run i18n && nextron build --no-pack

ironfish-node-app@3.0.17 i18n
npm run extract:i18n && npm run compile:i18n

ironfish-node-app@3.0.17 extract:i18n
formatjs extract "renderer/{pages,components,sections,layouts,ui}/**/*.{js,ts,tsx}" --format crowdin --id-interpolation-pattern "[sha512:contenthash:base64:6]" --out-file renderer/intl/locales/en-US.json

ironfish-node-app@3.0.17 compile:i18n
formatjs compile-folder --ast --format crowdin renderer/intl/locales renderer/intl/compiled-locales

[@formatjs/cli] [WARN] Error validating message "undefined" with ID "tU2A8W" in file "renderer/intl/locales/id-ID.json"
TypeError: Cannot read properties of undefined (reading 'length')

Possibly need to run npm run extract:i18n && npm run compile:i18n on the branch again to make sure it works

change Message to message. case sensitive
@ykris45 ykris45 requested a review from danield9tqh August 20, 2025 15:32
- Fix Indonesian translation plural format in id-ID.json
- Add "id-ID" to LOCALES constant in intl-constants.ts
- Resolve TypeScript errors for Indonesian language support
@ykris45
Copy link
Contributor Author

ykris45 commented Aug 20, 2025

@danield9tqh thank you daniel

@ykris45
Copy link
Contributor Author

ykris45 commented Aug 20, 2025

Merge merge.

@danield9tqh danield9tqh merged commit d524c37 into iron-fish:main Aug 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants