Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#242] Create custom keycloak image for testing #371

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

MartinFlores751
Copy link
Contributor

The environment should start the same on every standup by using the realm export. Asymmetric keys are only good for 10 years, I think. Remember to update before then!

@MartinFlores751
Copy link
Contributor Author

Rebuild image again for sanity check. Take out of draft if good.

@MartinFlores751 MartinFlores751 marked this pull request as ready for review November 15, 2024 18:59
@MartinFlores751
Copy link
Contributor Author

Builds good. Any future config changes should likely only see the example-realm-export.json change...

@MartinFlores751
Copy link
Contributor Author

I think we can use #242 for this.

@trel
Copy link
Member

trel commented Nov 15, 2024

242 feels good and right.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include words about the asymmetric keys in the README too.

Include as much info that seems helpful to the developer as possible.

test/keycloak/irods-http-api-keycloak.Dockerfile Outdated Show resolved Hide resolved
test/keycloak/irods-http-api-keycloak.Dockerfile Outdated Show resolved Hide resolved
test/keycloak/irods-http-api-keycloak.Dockerfile Outdated Show resolved Hide resolved
@trel
Copy link
Member

trel commented Nov 15, 2024

can make a test/README.md to keep it scoped, if that seems a good idea.

Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments. Solid Dockerfile

test/keycloak/irods-http-api-keycloak.Dockerfile Outdated Show resolved Hide resolved
@MartinFlores751 MartinFlores751 changed the title [???] Create custom keycloak image for testing [#242] Create custom keycloak image for testing Nov 21, 2024
@MartinFlores751
Copy link
Contributor Author

Suggestions on the README would be appreciated!

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My README suggestion is basically... pretend Alan is asking you how to run these tests. What are you going to tell me to type to get the tests to run? I feel that would be very helpful.

test/README.md Outdated Show resolved Hide resolved
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the write-up - looking good

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in a good spot and ready for squashing. Maybe wait for one other opinion first.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very close.

I think one more pass over it and this will be ready.

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash it!

@MartinFlores751
Copy link
Contributor Author

Squashed. I think we should move, or add, the commit message to the keycloak readme.

@korydraughn
Copy link
Contributor

You're referring to the part about the secret keys and 10 years?

I agree that should be captured in a README. Please do that.

@MartinFlores751
Copy link
Contributor Author

Added.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you address that final review comment, squash and pound it.

This gives us a good foundation to work with.

test/keycloak/README.md Outdated Show resolved Hide resolved
@MartinFlores751
Copy link
Contributor Author

Squashed and pounded!

@trel
Copy link
Member

trel commented Dec 18, 2024

go go go!

@trel
Copy link
Member

trel commented Dec 18, 2024

you want the 10y and 'remember' in the commit message?

@MartinFlores751
Copy link
Contributor Author

Would you prefer a more general reminder in the commit, or none at all?

More general: Keycloak secret keys will eventually expire. Update secrets before expiration.

Or the previous with the last sentence dropped?

@trel
Copy link
Member

trel commented Dec 18, 2024

i don't think the commit message makes sense for that information. just remove it i think.

i see it in the README - which does make sense.

@MartinFlores751
Copy link
Contributor Author

Removed the commit message.

@alanking alanking merged commit 5f25613 into irods:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants