Open
Conversation
panditsa
reviewed
Feb 4, 2026
| // Create fused load: select(lane_id < waveSize/2, ptrA, ptrB). | ||
| Location loc = op.getLoc(); | ||
| OpBuilder::InsertionGuard guard(rewriter); | ||
| rewriter.setInsertionPoint(loadA); |
Contributor
There was a problem hiding this comment.
- rewriter.setInsertionPoint(loadA);
+ Operation *insertionPoint = loadA->isBeforeInBlock(loadB) ? loadB : loadA;
+ rewriter.setInsertionPoint(insertionPoint);
This was a change I needed to make for a larger gemm test.
tgymnich
reviewed
Feb 4, 2026
| "::mlir::gpu::GPUDialect", | ||
| ]; | ||
| let options = [ | ||
| Option<"waveSize", "wave-size", "unsigned", /*default=*/"32", |
Contributor
There was a problem hiding this comment.
it does not make sense to have a default value here. The wave size should always be set intentionally and correctly, there is no real default that always works.
tgymnich
reviewed
Feb 4, 2026
| elemOps.push_back(value.getDefiningOp()); | ||
| value = value.getDefiningOp()->getOperand(0); | ||
| } | ||
| std::reverse(elemOps.begin(), elemOps.end()); |
Contributor
There was a problem hiding this comment.
Suggested change
| std::reverse(elemOps.begin(), elemOps.end()); | |
| llvm::reverse(elemOps); |
Hardcode84
force-pushed
the
scales-fusion-mlir
branch
from
c8f3885 to
5fcb6d2
Compare
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Hardcode84
force-pushed
the
scales-fusion-mlir
branch
from
5fcb6d2 to
c4748cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.