Conversation
tgymnich
force-pushed
the
tim/permute-op
branch
4 times, most recently
from
474d06e to
9dd20e3
Compare
tgymnich
force-pushed
the
tim/permute-op
branch
from
9dd20e3 to
dda879e
Compare
tgymnich
force-pushed
the
tim/permute-op
branch
from
dda879e to
bb65e50
Compare
martin-luecke
requested changes
Jan 23, 2026
Contributor
martin-luecke
left a comment
martin-luecke
left a comment
There was a problem hiding this comment.
wave.permute uses the new CompatibleOperandsAndResultsIgnoreShapeOpTrait as verifier for its input and return values, which ignores the shape entirely.
But for a permute the rank should match, and the target_shape should be a permutation of the input symbols. I think we should enforce this in the verifier, otherwise we can end up with mismatched ranks or symbol sets that later assert (e.g., zip_equal) or mis‑infer.
Also, I think I found a couple of propagation issues I’ve flagged inline.
ftynse
reviewed
Jan 24, 2026
ftynse
reviewed
Jan 26, 2026
tgymnich
force-pushed
the
tim/permute-op
branch
5 times, most recently
from
47200f9 to
b96f4d3
Compare
martin-luecke
approved these changes
Jan 30, 2026
Contributor
martin-luecke
left a comment
martin-luecke
left a comment
There was a problem hiding this comment.
With the changes this LGTM with a few nits still to address
tgymnich
force-pushed
the
tim/permute-op
branch
4 times, most recently
from
18fb408 to
abfbda5
Compare
Signed-off-by: Tim Gymnich <tim@gymni.ch>
tgymnich
force-pushed
the
tim/permute-op
branch
from
abfbda5 to
4c1d51c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
wave.permuteop that permutes dimensions of aWaveTensorInRegister.Lowers to a no-op, but modifies propagation of index expressions by permuting the strides according to
target_shape.