Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DispatchFormation] Fix CollapseDimensions for dynamic dimensions (and other things) #19336

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DispatchFormation] Fix CollapseDimensions for dynamic dimensions (and other things) #19336

wants to merge 3 commits into from

Conversation

Groverkss
Copy link
Contributor

  • Fixes CollapseDimensions to work properly on dynamic dimensions
  • Fixes CollapseDimensions thinking that the first input map in a linalg.generic represents the whole iteration space (why :( )
  • Fixes CollapseDimensions to not assume that a loop for a producer is not collapsable if the consumer doesn't contain it. This always happens for reduction dimensions.

@Groverkss
Copy link
Contributor Author

Need to add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@IanWood1 IanWood1 Awaiting requested review from IanWood1 IanWood1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Groverkss