-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace template_path with template_paths #1532
Conversation
Update changelog file with the changes of pr #1532 |
I appreciate the PR. Some CI checks are still failing, for example with this error:
Would you be so kind please and could check why it cannot pass? |
The problem is that nbconvert 6.1 dropped support for Python 3.6 (https://nbconvert.readthedocs.io/en/latest/install.html#supported-python-versions) and all the CI checks are for Python < 3.7. |
To correct myself, the current version of nbconvert is 6.0.7, and according to its documentation: |
Hi @demotu
Do you have any idea, who could be capable / allowed doing this for this repo? |
I think we just have to change the .travis.yml file; I will do that in my fork and I let you know. One detail is that I think the warning messages shown in #1529 (comment) are in fact generated by the jupyter_latex_envs extension, which has also to change to 'template_paths' (related pull request there, jfbercher/jupyter_latex_envs#58). |
@demotu / @stefansimik – any update on this? |
Only @demotu can save us :-) |
promise I will do it in two days. |
tests for python versions: 3.6, 3.7, 3.8 tests only for notebook 6.0.0
part of the tests using python 3.8 and notebook 6.0.0
drop support for python 2.x requires notebook >=6.0
drop support for python < 3.6 supports only PYTHON_ARCH: '64'
Drop support for python < 3.6
Drop support for python < 3.6
Drop support for python < 3.6
I didn't notice I was also committing to master all the time. Some of the previous CI tests failed for strange reasons, but jupyter_contrib_nbextensions '0.5.2' runs fine in my local installation with linux, miniconda, python 3.8.6 and notebook 6.1.5. |
Most of the CI tests fail with message (https://travis-ci.org/github/ipython-contrib/jupyter_contrib_nbextensions/jobs/747348271): It seems it's a common error using jinja2, e.g.: I will try to fix. |
Any plans for merging this? |
|
Sorry for the long wait. Merging and trying to fix the CI tests afterwards. |
Thank you @juhasch |
Still seeing this problem in 2022-05. Multiple error messages on starting up Jupyter Lab: |
Yeah, that's true. |
So what still needs to be done to fix this? With a clean install (done yesterday), removing all of the old config files, and replacing |
Exactly, with clean install, it still does not work. |
The |
I have installed the latest version,but still can not fix the problem. |
The issue should be fixed from our side. Please check if you still have |
I can confirm it works with the latest version (jupyter-contrib-nbextensions 0.7.0 via pip). Thanks. |
Does also export as I tested, and it worked - i.e. output HTML file was generated without any errors in console, but the final content of the file was partially wrong - because the main point - the TOC was completely missing and at its place text |
Yes, it shows the TOC correctly when using the menu option |
Thanks for confirmation. |
This is the right repo to report this issue. Unfortunately, the original author is no longer active, so fixing things takes time. The Jupyter configuration system is not so easy to understand, but basically the An attempted fix can be found in PR #1622. |
Nbconvert 6.0 replaced 'template_path' with 'template_paths' (see https://nbconvert.readthedocs.io/en/latest/changelog.html#significant-changes).
This change in Nbconvert causes errors in jupyter_latex_envs and in jupyter_contrib_nbextensions (see #1529).
Replacing all instances of 'template_path' with 'template_paths' in both jupyter_latex_envs and in jupyter_contrib_nbextensions fixes the error.