-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use black
formatter by default
#1452
base: master
Are you sure you want to change the base?
Conversation
Although I like this idea, it looks like the black API has changed recently, so this doesn't always work. On my current installation (black 19.3b0), this throws
while the method signature appears to expect a filemode dataclass object (see Thanks for the PR, btw 👍 |
That's strange, it's working on me with black 19.3b0. I'm on Windows 7, with Miniconda on "conda-forge" channel. |
Hmm, curiouser & curiouser. I'm on macOs, using 19.3b0 from PyPi. I'll try to give it a shot on windows at some point. Alternatively, perhaps it would be worth adding python tests for these snippets... |
Really great idea! |
Now it works with the new Black API. |
Thanks for this PR. Is it ready to be merged ? |
I think it has been for a while already... |
Based on: https://gist.github.com/MarvinT/a072aa992e977496974aaf492287b08c#file-black_code_prettify-json