Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ziggogo.tv #2522

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

BellezaEmporium
Copy link
Contributor

@BellezaEmporium BellezaEmporium commented Dec 19, 2024

  • New endpoints used in Ziggo, old endpoints still work, but for safety measures these are changed to fit what's being used currently. The program details didn't seem to load using Axios, using Node's native fetch for that.
  • Tests have been updated.
  • Test data has been updated.

Copy link
Collaborator

@freearhey freearhey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failed:

npm test --- ziggogo.tv

> test
> run-script-os ziggogo.tv


> test:default
> TZ=Pacific/Nauru npx jest --runInBand ziggogo.tv

 FAIL  sites/ziggogo.tv/ziggogo.tv.test.js (13.284 s)
  ✓ can generate valid url (6 ms)
  ✕ can parse response (10002 ms)
  ✓ can handle empty guide (2 ms)

  ● can parse response

    thrown: "Exceeded timeout of 10000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      24 | })
      25 |
    > 26 | it('can parse response', async () => {
         | ^
      27 |   const content = fs.readFileSync(path.resolve(__dirname, '__data__/content_0000.json'))
      28 |
      29 |   axios.get.mockImplementation(url => {

      at Object.<anonymous> (sites/ziggogo.tv/ziggogo.tv.test.js:26:1)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 2 passed, 3 total
Snapshots:   0 total
Time:        13.498 s
Ran all test suites matching /ziggogo.tv/i.
Jest did not exit one second after the test run has completed.

'This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.

@BellezaEmporium
Copy link
Contributor Author

Will check.

@tohenk
Copy link
Collaborator

tohenk commented Dec 20, 2024

This site is similar with sites/virgintvgo.virginmedia.com i've just worked a while ago.

@BellezaEmporium
Copy link
Contributor Author

I'm quite sure your method would also work on ziggogo.tv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants