-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] ziggogo.tv #2522
Open
BellezaEmporium
wants to merge
7
commits into
master
Choose a base branch
from
bellezaemporium/fixes/ziggogo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Fix] ziggogo.tv #2522
+45
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BellezaEmporium
commented
Dec 19, 2024
•
edited
Loading
edited
- New endpoints used in Ziggo, old endpoints still work, but for safety measures these are changed to fit what's being used currently. The program details didn't seem to load using Axios, using Node's native fetch for that.
- Tests have been updated.
- Test data has been updated.
freearhey
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failed:
npm test --- ziggogo.tv
> test
> run-script-os ziggogo.tv
> test:default
> TZ=Pacific/Nauru npx jest --runInBand ziggogo.tv
FAIL sites/ziggogo.tv/ziggogo.tv.test.js (13.284 s)
✓ can generate valid url (6 ms)
✕ can parse response (10002 ms)
✓ can handle empty guide (2 ms)
● can parse response
thrown: "Exceeded timeout of 10000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
24 | })
25 |
> 26 | it('can parse response', async () => {
| ^
27 | const content = fs.readFileSync(path.resolve(__dirname, '__data__/content_0000.json'))
28 |
29 | axios.get.mockImplementation(url => {
at Object.<anonymous> (sites/ziggogo.tv/ziggogo.tv.test.js:26:1)
Test Suites: 1 failed, 1 total
Tests: 1 failed, 2 passed, 3 total
Snapshots: 0 total
Time: 13.498 s
Ran all test suites matching /ziggogo.tv/i.
Jest did not exit one second after the test run has completed.
'This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.
Will check. |
This site is similar with sites/virgintvgo.virginmedia.com i've just worked a while ago. |
I'm quite sure your method would also work on ziggogo.tv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.