-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EPG usage in Docker. #2488
base: master
Are you sure you want to change the base?
Add EPG usage in Docker. #2488
Conversation
It doesn't hurt to let people know how to use EPG in Docker. Signed-off-by: Toha <[email protected]>
I did something very similar to you at this repo of mine. Maybe the way I build the image isn't the best (in that case feel free to reach out), but I think it offers the advantage of being easier to deploy. I think that using Docker for deployment is a really good idea, so at some point I build an image for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally do not mind having this in the README, now it'll be up to @freearhey to see if it fits better in /epg or in /awesome-iptv
I'm in favor of the iptv-org/awesome-iptv or you can create |
Tbh I don't really understand why the iptv-org/epg repo doesn't contain a Dockerfile. Furthermore I think that a precompiled image would be much more desirable. Instead of looking like this :
The image could look like this :
Further more using an alpine based image would reduce the size considerably. |
For me, it doesn't hurt having a Dockerfile inside iptv-org/epg. After all, since we cannot make the EPGs ourselves via GH, we can give a much more convenient way for people to generate them (even adding crons and maintaining a little live server which scrapes EPGs periodically !) |
That is exactly what I was thinking. The reason I haven't submitted a PR myself is because I wanted to discuss it before. |
Let me make a proposal about how to make a Docker image. First of all we would need a serve.json file that looks like this :
The reasoning behind this is that we don't want to serve all the files to the outside world. Later on we will create symbolic links into the /public directory. Secondly comes the
And last but not least the Dockerfile would look like this :
|
It doesn't hurt to let people know how to use EPG in Docker.