-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: libp2p resource management #9468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: the first commit of libp2p-resource-management.md was a copy from config.md. You can see the changes I made on top with followup commits.
✅ |
Remove content from config.md Point to libp2p-resource-managent.md from rcmgr_logging.go
Co-authored-by: Antonio Navarro Perez <[email protected]>
c7804b5
to
d5cc846
Compare
I added a changelog entry for the work. @lidel : my default would be for you to review/merge, but feel free to say "skip" and we'll let @ajnavarro handle it. |
56bf611
to
1cfef6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pushed small editorial changes and fixed test.
In an attempt to address some of the resource manager integration concerns from #9442 , this is a start to docs dedicated on Kubo's integration with libp2p resource management. A lot of this information previously lived in the config docs, but since the scope was expanding beyond configuration, it was pulled into its own doc.
This isn't currently complete, but is hopefully a starting branch for others to expand and improve upon.
For anyone looking at this, these docs are assuming functionality that will land for 0.18 as being tracked in #9442