Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid unknown fields on config #9438

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: Avoid unknown fields on config #9438

wants to merge 2 commits into from
+181 −143

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented Nov 30, 2022 •
edited
Loading

This will reduce headaches when adding wrong fields to the config.

Signed-off-by: Antonio Navarro Perez [email protected]

@ajnavarro ajnavarro changed the title Avoid unknown fields on config fix: Avoid unknown fields on config Nov 30, 2022
@ajnavarro ajnavarro self-assigned this Dec 1, 2022
@BigLep
Copy link
Contributor

BigLep commented Dec 1, 2022

2022-12-01 standup conversation:

  • Agreed on strict mode by default
  • Provide environment variable to bypass validation
  • We want to keep strict mode as possible for sharness
  • We should have a test that validates that strict mode does raise an error when you use an invalid strict

@BigLep BigLep requested a review from Jorropo December 1, 2022 15:59
@BigLep BigLep mentioned this pull request Dec 1, 2022
Closed
9 tasks
@ajnavarro ajnavarro force-pushed the fix/avoid-wrong-fields-on-config branch from c71844b to d476c5d Compare December 2, 2022 16:15
@ajnavarro
Avoid unknown fields on config
39d10ea 
This will reduce headaches when adding the wrong fields to the config.

Signed-off-by: Antonio Navarro Perez <[email protected]>
@ajnavarro
Fix more sharness tests
0bff00e 
Signed-off-by: Antonio Navarro Perez <[email protected]>
@ajnavarro ajnavarro force-pushed the fix/avoid-wrong-fields-on-config branch from d476c5d to 0bff00e Compare December 2, 2022 16:54
@BigLep BigLep mentioned this pull request Dec 7, 2022
Closed
@ajnavarro ajnavarro removed their assignment Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Awaiting requested review from Jorropo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Status: 🥞 Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnavarro @BigLep