chore: dependency update for 0.31 #10511
Open
+191
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Sep 11, 2024
There was a problem hiding this comment.
ℹ️ these changes are introduced by prometheus update
lidel
commented
Sep 11, 2024
| @@ -94,7 +96,6 @@ go_memstats_heap_objects | |||
| go_memstats_heap_released_bytes | |||
| go_memstats_heap_sys_bytes | |||
| go_memstats_last_gc_time_seconds | |||
| go_memstats_lookups_total | |||
There was a problem hiding this comment.
ℹ️ Rationale for removal in https://github.com/prometheus/client_golang/releases/tag/v1.20.0 ("was broken anyway")
gammazero
reviewed
Sep 17, 2024
| go 1.22 | ||
| go 1.22.0 | ||
|
|
||
| toolchain go1.23.0 |
There was a problem hiding this comment.
Do you really want this toolchain?
gammazero
reviewed
Sep 17, 2024
| @@ -251,4 +251,6 @@ require ( | |||
| lukechampine.com/blake3 v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| go 1.22 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
Seems too specific. I think we want go 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go get -udid not work well, so did manual bump of selected ones as the last step of Release 0.30 #10436 (comment) and preparation for 0.31 (Release 0.31 #10499)