Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip changelog]Fix issue in ResourceManager and nopfsPlugin about repo path #10492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[skip changelog]Fix issue in ResourceManager and nopfsPlugin about repo path #10492

wants to merge 3 commits into from

Conversation

fengzie
Copy link

@fengzie fengzie commented Aug 24, 2024

For ResourceManager and nopfsPlugin, we need pass the Repo path for use, instead of getting from config.PathRoot(), which might not be the right one.

This will also fixes issue #10407 .

@fengzie fengzie requested a review from a team as a code owner August 24, 2024 03:19
@lidel lidel mentioned this pull request Aug 28, 2024
Open
31 tasks
@lidel
Copy link
Member

lidel commented Sep 10, 2024 •
edited
Loading

Triage notes:

  • we want to fix denylist support first, we plan to look into it in 0.31 (Release 0.31 #10499), then we will revisit this PR
    • understand why we need it, and was not a problem before

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengzie @lidel