-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update boxo for bitswap providing refactor #10270
base: master
Are you sure you want to change the base?
Conversation
cddb003
to
030fe26
Compare
There used to be a bug where files could take minutes if not hours to be accessible after |
After testing I think this also fixes #10011 because we don't keep CIDs providing queue in memory (as much), the queue is handled by badger or leveldb which writes to disk. The providing also goes much faster. Might not fix it completely, but it certainly help. |
So after adding 15k blocks:
Before this patch: RSS is at 512MiB and climbing. I don't know if I fixed #10011 but whatever this is it's a great improvement. |
20dca9d
to
c19ef6f
Compare
22130d0
to
311cd6c
Compare
311cd6c
to
732d56c
Compare
@Jorropo I can take a better look once you have the Go tests and the sharness passing |
@hacdias I didn't because I'm doing more things (rewriting the server) and wanted to handle all of this in kubo at once. |
There's a large set of interlinked PRs here. Trying to understand which are the independent sets of changes here and why we want/need them. As I understand we have:
A couple other things that got hit along the way in the PR chain:
@Jorropo does this look about right to you? |
If I've got this right it seems like the next steps should be:
|
Keeps in sync with: - ipfs/boxo#578 - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
732d56c
to
dae471e
Compare
Keeps in sync with:
I also took time to cleanup how we handle offline dag service and offline blockservice (I added them to the
fx
🪄✨) as now blockservice has the side effect of providing (instead of exchange (bitswap)).