Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing/dht/zikade): add dht routing implementation using zikade #472

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

iand
Copy link
Contributor

@iand iand commented Sep 26, 2023

Add support for the Zikade Amino DHT implementation as a routing choice.

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

routing/dht does not exists btw, no need to add v2

@iand
Copy link
Contributor Author

iand commented Sep 26, 2023

routing/dht does not exists btw, no need to add v2

Understood. I chose this on the assumption that dht v1 would still be needed for a while and might end up in Boxo. Happy to remove the v2 if needed

@iand iand changed the title feat(routing/dhtv2): add go-libp2p-kad-dht/v2 dht routing feat(routing/dht/zikade): add go-libp2p-kad-dht/v2 dht routing Sep 28, 2023
@BigLep
Copy link
Contributor

BigLep commented Oct 2, 2023

@iand : just in case this was an accident, the team teans to not look at draft PRs. Please callout if you're wanting feedback on the current state (or move out of draft).

@iand
Copy link
Contributor Author

iand commented Oct 2, 2023

@BigLep it's not an accident, I wanted early visibility while I am working on it. Will mark it ready for review when complete.

@iand iand changed the title feat(routing/dht/zikade): add go-libp2p-kad-dht/v2 dht routing feat(routing/dht/zikade): add dht routing implementation using zikade Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #472 (77fabf8) into main (ba5ba1a) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   65.57%   65.51%   -0.06%     
==========================================
  Files         207      207              
  Lines       25543    25543              
==========================================
- Hits        16749    16735      -14     
- Misses       7323     7335      +12     
- Partials     1471     1473       +2     

see 11 files with indirect coverage changes

@iand iand marked this pull request as ready for review November 1, 2023 15:39
@iand iand requested a review from a team as a code owner November 1, 2023 15:39
@iand
Copy link
Contributor Author

iand commented Nov 1, 2023

@Jorropo would you be able to take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

3 participants