Support multiple Architectures in build_p4sde.sh #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed markdown in readme file Signed-off-by: Asaf Ravid <[email protected]>
Instead of implicitly using x86_64, use uname -m to detect architecture and parameterize lib/x86_64-linux-gnu/pkgconfig Signed-off-by: Asaf Ravid <[email protected]>
mestery
approved these changes
Feb 23, 2022
| @@ -137,7 +137,7 @@ for creating the vhost socket interfaces in `volume/intf`, all the log files in | |||
| `volume/logs` and can be used to share files with the IPDK daemon container | |||
| where the `VOLUME` directory is available as '/tmp'. | |||
|
|
|||
| * Run - 'ipdk connect' - To connect to your IPDK container daemon and to use | |||
| * Run - `ipdk connect` - To connect to your IPDK container daemon and to use | |||
There was a problem hiding this comment.
Not related to your commit, but fine to merge with this anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markdownwithin Readme