Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filib #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update filib #122

wants to merge 1 commit into from

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Sep 21, 2024

Description

Update filib and ensure it is linked as a shared library to avoid licensing IPC Toolkit under LGPL

Filib is still completely optional and can be disabled entirely (if LGPL is too scary 😜).

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

Checklist:

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (a34c034) to head (18608f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   96.32%   96.31%   -0.02%     
==========================================
  Files         102      102              
  Lines        7601     7601              
==========================================
- Hits         7322     7321       -1     
- Misses        279      280       +1     
Flag Coverage Δ
unittests 96.31% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant