Remove Byte String Prefix in Output #5179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwilightTechie
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
ekyooo
reviewed
Dec 24, 2024
tools/klockstat.py
Outdated
| @@ -431,7 +431,7 @@ def display(sort, maxs, totals, counts): | |||
|
|
|||
| avg = totals[k].value / counts[k].value | |||
|
|
|||
| print("%40s %10lu %6lu %10lu %10lu" % (caller, avg, counts[k].value, maxs[k].value, totals[k].value)) | |||
| print("%40s %10lu %6lu %10lu %10lu" % (caller.decode('utf-8'), avg, counts[k].value, maxs[k].value, totals[k].value)) | |||
There was a problem hiding this comment.
Could you provide a second argument to prevent a UnicodeDecodeError, similar to how other tools handle it?
caller.decode('utf-8', 'replace')
There was a problem hiding this comment.
Hi @ekyooo thanks for the review, I have updated the PR. Do let me know if anything else is required.
TwilightTechie
force-pushed
the
master
branch
from
d0b2b1b to
fba9b78
Compare
Byte strings are printed directly, leading to output with the 'b'
prefix
example:
Caller Avg Spin Count Max spin Total spin
b'ep_poll+0x16b' 1096 26576 8180 29145121
b'drm_fb_helper_damage_work+0x97' 1705 32 2870 54580
b'process_one_work+0x178' 1325 55 2520 72879
b'ext4_evict_inode+0x283' 1625 11 2400 17880
This fix decode the byte strings
After fix:
Caller Avg Spin Count Max spin Total spin
process_one_work+0x178 1569 24 3530 37657
ep_poll+0x16b 1037 12 3090 12450
kthread+0xf2 2336 3 2830 7010
rcu_tasks_kthread+0xa4 1642 5 2490 8210
Signed-off-by: Anup Sharma <[email protected]>
TwilightTechie
force-pushed
the
master
branch
from
fba9b78 to
f897273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte strings are printed directly, leading to output with the 'b' prefix
example:
Caller Avg Spin Count Max spin Total spin
b'ep_poll+0x16b' 1096 26576 8180 29145121
b'drm_fb_helper_damage_work+0x97' 1705 32 2870 54580
b'process_one_work+0x178' 1325 55 2520 72879
b'ext4_evict_inode+0x283' 1625 11 2400 17880
This fix decode the byte strings
After fix:
Caller Avg Spin Count Max spin Total spin
process_one_work+0x178 1569 24 3530 37657
ep_poll+0x16b 1037 12 3090 12450
kthread+0xf2 2336 3 2830 7010
rcu_tasks_kthread+0xa4 1642 5 2490 8210