Skip to content

Conversation

@martaw22
Copy link

@martaw22 martaw22 commented Dec 5, 2025

Add the option of a fail flag to the rate of change test

  • Most QARTOD manuals only define a suspect flag for the rate of change test
  • However, the currents manual requires a fail flag for the this test: https://cdn.ioos.noaa.gov/media/2019/08/QARTOD_Currents_Update_Second_Final.pdf
  • This update adds the flag as an optional arg, updates the docstring for the roc test, and adds test_rate_of_change_fail_flag
  • The default for the rate of change test will still only use the suspect flag

Fixes #101

The currents manual requires a fail flag for the roc test.
This also updates the docstring for the roc test and adds a new test
for this flag
The default is still to use the suspect flag only

Resolves: ioos#101
@ocefpaf ocefpaf merged commit 242dabd into ioos:main Dec 10, 2025
33 checks passed
@ocefpaf
Copy link
Member

ocefpaf commented Dec 10, 2025

Thanks @martaw22! I'll mint a new release ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to add optional fail threshold to rate_of_change_test

2 participants