chore(angular): update dependencies for v19, use latest control flow syntax and build #1858
+244
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
commented
Dec 13, 2024
There was a problem hiding this comment.
Typescript needs to be pinned to minor here because version 5.7.2 causes errors with vue-tsc. This prevents the build from passing on this PR: https://github.com/ionic-team/starters/actions/runs/12321151698/job/34391988149?pr=1858
brandyscarney
changed the title
brandyscarney
changed the title
brandyscarney
requested review from
BenOsodrac and
thetaPC
and removed request for
a team
thetaPC
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Since this file is already being edited, can we add a new line to the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
angularandangular-standaloneto Angular v19@ionic/angular-toolkitto v12eslintto v9@forinstead of*ngFor)angular-standaloneto the new build system via theapplicationbuilder