RMET-3900 :: bridge :: add getCurrentPosition wrapper for both capacitor and cordova
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+5
to
+24
| export type OSGLOCPosition = { | ||
| timestamp: number; | ||
| latitude: number; | ||
| longitude: number; | ||
| accuracy: number; | ||
| altitude: number | null; | ||
| speed: number | null; | ||
| heading: number | null; | ||
| altitudeAccuracy: number | null; | ||
| }; | ||
| export type LegacyOSPosition = { | ||
| timestamp: number; | ||
| latitude: number; | ||
| longitude: number; | ||
| accuracy: number; | ||
| altitudeAccuracy: number | null | undefined; | ||
| altitude: number | null; | ||
| velocity: number | null; | ||
| heading: number | null; | ||
| }; |
There was a problem hiding this comment.
Do we need both? They are identical so I was wondering if we could reuse one of them.
There was a problem hiding this comment.
should be fixed!
OS-martacarlos
force-pushed
the
feat/RMET-3900/get-location
branch
from
81e3eb1 to
1fa586f
Compare
Comment on lines
+41
to
+42
| if (this.#lastPosition && options.maximumAge && (((new Date()).getTime() - this.#lastPosition.timestamp) <= options.maximumAge)) { | ||
| success(this.#lastPosition); |
There was a problem hiding this comment.
I see this was taken from how the cordova plugin was setup - but On Android, this logic is being managed by the actual FusedLocationProviderClient. I don't know how it is on iOS, but if there is analagous logic, perhaps there is no need to store the lastPosition in this wrapper.
There was a problem hiding this comment.
I checked with @OS-ricardomoreirasilva and iOS does not have this logic, so it needs to exist here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a wrapper to the plugin, adding timeout logic for
getCurrentPosition.The main goal is to use this code inside the OutSystems Plugin, but it can also be used outside of it. I
As it already uses
CapacitorUtils.Synapseit's ready for both cordova and capacitor plugins.It can also detect if an old build of the plugin is being used (aka the old
cordova-geolocation-plugin)Type of changes
Platforms affected
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>