feat(textarea): adjusting min-height of the textarea for ionic theme#30957
Open
rugoncalves wants to merge 22 commits intonextfrom
Open
feat(textarea): adjusting min-height of the textarea for ionic theme#30957rugoncalves wants to merge 22 commits intonextfrom
rugoncalves wants to merge 22 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where textareas with the rows attribute set to 1 (or other values) would not properly respect the row count due to forced min-height values in the Ionic theme. The fix adjusts padding placement and removes fixed min-height constraints when the rows attribute is present.
Changes:
- Removed hardcoded
min-heightvalues from.textarea-size-*classes in the Ionic theme - Added
min-height: autooverride for textareas with therowsattribute - Moved padding from
.textarea-wrapper-innerto.native-textareawhenrowsis set (for proper scrolling behavior) - Added comprehensive e2e tests for the
rowsfunctionality
Reviewed changes
Copilot reviewed 4 out of 91 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
textarea.ionic.scss |
Removed min-height from size classes; added padding redistribution for rows attribute |
textarea.common.scss |
Added min-height: auto override for textareas with rows attribute |
test/rows/textarea.e2e.ts |
New comprehensive test suite for rows functionality |
test/rows/index.html |
New manual testing page for rows feature |
| Various snapshot files | Updated visual regression test snapshots |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…amework into ROU-12443-v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
heightof the textarea would not correspond to the rows number, when it the row number was set to1:What is the new behavior?
min-heightis now respecting the rows attribute:.textarea-size-*classes stopped forcing themin-height;Does this introduce a breaking change?
Other information