feat(select): add wrapper and bottom shadow parts#30951
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
left a comment
There was a problem hiding this comment.
This looks fine to me, the only minor concern I have is that there's no visual regression tests, but that's probably fine. No idea.
That makes sense, but @brandyscarney has made good points of why we shifted over to use this new approach to test parts. I just can't seem to remember what it was. Maybe less snapshots for us to maintain? |
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good! Just requesting a name update on one.
|
Sorry I missed your previous comments. We don't need screenshot tests here since we're defining the colors ourselves. If these were the default colors for the elements we would verify them visually to ensure they look correct because the defaults may change frequently. Because we're defining what color the token should use we can just verify that the right element is styled by it. |
Issue number: resolves #29918
What is the current behavior?
Developers can't customize elements within select like the bottom container because the component is a shadow component.
What is the new behavior?
bottom,wrapper, andwrapper-innerpartsDoes this introduce a breaking change?
Other information
N/A