Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix locationHistory incorrect when history pop #29769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix locationHistory incorrect when history pop #29769

wants to merge 1 commit into from

Conversation

gzqby
Copy link

@gzqby gzqby commented Aug 13, 2024 •
edited
Loading

Issue number: resolves #29721

What is the current behavior?

  1. The routing stack of locationHistory is missing in certain situations, for example, when entering the application from a non-home page, the routing stack is incomplete. At the same time, when the iPhone gesture is used to back off, the routing stack cannot be completed.
  2. bug: ion-router-outlet does not show correct page after vue-router navigation guard was used #29721 Looks like the same problem.https://stackblitz.com/edit/vitejs-vite-vphseq?file=README.md

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

no

@gzqby gzqby requested a review from a team as a code owner August 13, 2024 12:58
@gzqby gzqby requested a review from thetaPC August 13, 2024 12:58
@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:01pm

@github-actions github-actions bot added the package: vue @ionic/vue package label Aug 13, 2024
@MervinDelfin MervinDelfin mentioned this pull request Nov 9, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC Awaiting requested review from thetaPC thetaPC is a code owner automatically assigned from ionic-team/framework

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ion-router-outlet does not show correct page after vue-router navigation guard was used
1 participant
@gzqby