Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run clean, build and test with verify:ios #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pwespi
Copy link
Contributor

@pwespi pwespi commented Jan 26, 2021

Currently unit tests are not run with verify:ios.

verify:android runs clean build test, so verify:ios should probably do the same.

@imhoffd
Copy link
Contributor

imhoffd commented Jan 27, 2021

LGTM

I guess my only concern would be how to keep the "preferred simulator" up to date if it's hard-coded in each plugin's package.json.

@imhoffd imhoffd requested a review from jcesarmobile January 27, 2021 02:14
@pwespi
Copy link
Contributor Author

pwespi commented Jan 27, 2021

Thanks for your feedback. I also don't like the hard-coded iPhone version, but didn't find another way.

Without the -destination ... flag, I was getting:

Testing failed:
        Signing for "PluginTests" requires a development team. Select a development team in the Signing & Capabilities editor.
        Testing cancelled because the build failed.

I also tried -sdk iphonesimulator instead of the -destination ..., but then I was getting:

xcodebuild: error: Failed to build workspace Plugin with scheme Plugin.
        Reason: Cannot test target “PluginTests” on “Any iOS Simulator Device”: A build only device cannot be used to run this target. No supported devices are available running a compatible version of iOS Simulator. Connect a device with a newer version of iOS Simulator in order to run your application (or choose a simulated device as the destination).

If anyone has another idea, I'm happy to try it.

@pwespi
Copy link
Contributor Author

pwespi commented Mar 16, 2021

Seems that adding -destination \"platform=iOS Simulator,name=iPhone 12\" can also help with some pod dependency problems, see https://getcapacitor.slack.com/archives/C8AGVAMPZ/p1615813430012300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants