Open
Conversation
markemer
changed the title
android/capacitor/src/main/java/com/getcapacitor/BridgeActivity.java
Outdated
Show resolved
Hide resolved
android/capacitor/src/main/java/com/getcapacitor/MessageHandler.java
Outdated
Show resolved
Hide resolved
android/capacitor/src/main/java/com/getcapacitor/PluginLoader.java
Outdated
Show resolved
Hide resolved
Removed commented-out Cordova configuration initialization.
| }); | ||
| } | ||
|
|
||
| // TODO: How to we ensure this gets called? Should we punt and use reflection? |
| @@ -0,0 +1,6 @@ | |||
| //#import <Capacitor/Capacitor-Swift.h> | |||
Member
Author
There was a problem hiding this comment.
How'd these damn files sneak back in, they're in our current project and are useless as far as I know, we just moved them.
| @@ -0,0 +1,5 @@ | |||
| //#import "CAPBridgeViewController+CDVScreenOrientationDelegate.h" | |||
…cordova-cap8-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test instructions
The best way to test this is with 4 apps. (iOS and Android)
In all cases running
npx cap syncshould work as expected, not including Cordova when there are no plugins, and including it when there are.Some other things to try